[libvirt] [libvirt-jenkins-ci PATCH v2 2/6] guests: Introduce lcitool
phrdina at redhat.com
Thu Oct 19 12:53:40 UTC 2017
On Thu, Oct 19, 2017 at 02:42:15PM +0200, Andrea Bolognani wrote:
> On Thu, 2017-10-19 at 14:04 +0200, Pavel Hrdina wrote:
> > > > This script replaces the existing Makefile, and will be extended
> > > > to provide more functionality in future commits.
> > > >
> > > > It also takes over ownership of the Ansible vault password, which
> > > > is now expected to be stored in lcitool's own config directory
> > > > along with more settings that will be introduced later.
> > > >
> > > > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> > > > ---
> > > > guests/Makefile | 12 ---------
> > > > guests/ansible.cfg | 1 -
> > > > guests/lcitool | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > > 3 files changed, 76 insertions(+), 13 deletions(-)
> > > > delete mode 100644 guests/Makefile
> > > > create mode 100755 guests/lcitool
> > >
> > > FYI: I came up with a cuter name, licito, and I will use that when
> > > pushing unless someone feel strongly otherwise .
> > I liked manage better that lcitool, but lcitool makes sense as well.
> > However, I don't like licito, it might sound cool but IMHO it's not
> > useful at all.
> I liked 'manage' better as well but it's also extremely generic, so
> the moment we started writing data outside the source directory it
> was automatically off the table.
I agree with that, manage is not usable in this case.
> Neither of the other names is particularly useful, they're just
> names but at least they're both fairly unique and reasonably easy
> to remember. I think that 'licito' is a very fair name, and using
> it would definitely not be illegal :P
> So if your only argument against it is that you don't like it very
> much, my reply is that I do like it quite a bit and, well, I get to
> name the programs I write :)
Well, yes and no :) you can name the program but you also need to have
an ACK from community to accept that name. "licito" is just a cool name
that doesn't tell you anything from the first glance what it is. On the
other hand lcitool tells you that it's some kind of tool and that the
"lci" part specifies what kind of tool it is. It's not only that I
don't personally like it but it also looks like some randomly chosen
name even though there is some pattern behind it.
I vote for lcitool instead of licito.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the libvir-list