[libvirt] [PATCH] util: Missing 'removeTimeoutImpl' check variable inside virEventRegisterImpl() function.
John Ferlan
jferlan at redhat.com
Fri Oct 20 13:20:06 UTC 2017
On 10/19/2017 11:35 AM, Julio Faracco wrote:
> The function virEventRegisterImpl() checks the attempt to replace the
> registered events. But there is a duplicate variable inside the IF statement.
> The variable 'removeHandleImpl' was wrongly repeated. One of them needs to be
> replaced by 'removeTimeoutImpl'.
>
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
> src/util/virevent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Introduced by commit id '5f5c515bb'
Reviewed-by: John Ferlan <jferlan at redhat.com>
will push shortly...
Tks,
John
> diff --git a/src/util/virevent.c b/src/util/virevent.c
> index 51d8714..87069e3 100644
> --- a/src/util/virevent.c
> +++ b/src/util/virevent.c
> @@ -241,7 +241,7 @@ void virEventRegisterImpl(virEventAddHandleFunc addHandle,
> addTimeout, updateTimeout, removeTimeout);
>
> if (addHandleImpl || updateHandleImpl || removeHandleImpl ||
> - addTimeoutImpl || updateTimeoutImpl || removeHandleImpl) {
> + addTimeoutImpl || updateTimeoutImpl || removeTimeoutImpl) {
> VIR_WARN("Ignoring attempt to replace registered event loop");
> return;
> }
>
More information about the libvir-list
mailing list