[libvirt] [PATCH v2 00/11] Never ending story of user supplied aliases

Ján Tomko jtomko at redhat.com
Mon Oct 23 05:53:17 UTC 2017


On Fri, Oct 20, 2017 at 04:52:10PM +0200, Michal Privoznik wrote:
>v2 of:
>
>https://www.redhat.com/archives/libvir-list/2017-October/msg00790.html
>
>diff to v1:
>- new patch 1/11 to address Pavel's findings
>- reworked parsing so that the alias is set iff it follows the rules
>- added some tests
>- added news.xml entry
>
>Michal Privoznik (11):
>  qemu_alias: Be more tolerant if alias don't follow our format
>  conf: Parse user supplied aliases
>  conf: Validate user supplied aliases
>  qemuDomainABIStabilityCheck: Check for memory aliases too
>  qemuxml2argvdata: Drop device aliases
>  qemuhotplugtest: Load active XML
>  conf: Format alias even for inactive XMLs
>  docs: Document user aliases
>  qemu: Parse alias from inactive XMLs
>  tests: Test user set aliases for qemu
>  news: Document user aliases
>
> docs/formatdomain.html.in                          |  23 +++
> docs/news.xml                                      |   9 ++
> src/conf/domain_conf.c                             | 171 ++++++++++++++++++++-
> src/conf/domain_conf.h                             |   6 +
> src/libvirt_private.syms                           |   1 +
> src/qemu/qemu_alias.c                              |  22 +--
> src/qemu/qemu_domain.c                             |  18 ++-
> src/qemu/qemu_driver.c                             |   3 +
> tests/qemuhotplugtest.c                            |   3 +-
> .../qemuxml2argv-disk-cdrom-network-ftp.xml        |   1 -
> .../qemuxml2argv-disk-cdrom-network-ftps.xml       |   1 -
> .../qemuxml2argv-disk-cdrom-network-http.xml       |   1 -
> .../qemuxml2argv-disk-cdrom-network-https.xml      |   1 -
> .../qemuxml2argv-disk-cdrom-network-tftp.xml       |   1 -
> .../qemuxml2argv-usb-redir-filter.xml              |   1 -
> .../qemuxml2argv-user-aliases.args                 |  71 +++++++++
> .../qemuxml2argvdata/qemuxml2argv-user-aliases.xml | 140 +++++++++++++++++
> tests/qemuxml2argvtest.c                           |   5 +
> .../qemuxml2xmlout-user-aliases.xml                |   1 +
> tests/qemuxml2xmltest.c                            |   2 +
> 20 files changed, 449 insertions(+), 32 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-user-aliases.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-user-aliases.xml
> create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-user-aliases.xml
>

ACK series

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171023/4a9890a8/attachment-0001.sig>


More information about the libvir-list mailing list