[libvirt] [PATCH] virnetdaemon: Don't deadlock when talking to D-Bus

Christian Ehrhardt christian.ehrhardt at canonical.com
Fri Sep 1 09:50:12 UTC 2017


On Fri, Sep 1, 2017 at 10:39 AM, Michal Privoznik <mprivozn at redhat.com>
wrote:

> https://bugzilla.redhat.com/show_bug.cgi?id=1487322
>
> In ace45e67abbd I've tried to fix a problem that we get the reply
> to a D-Bus call while we were sleeping. In that case the callback
> was never set. So I've changed the code that the callback is
> called directly in this case. However, I hadn't realized that
> since callback is called out of order it lock the virNetDaemon.
> Exactly the very same virNetDaemon that we are dealing with right
> now and have it locked already (in
> virNetDaemonAddShutdownInhibition())
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>
>
Change builds fine (on top of 3.6) and seems to fix the issue.
Survived 20 minutes in my stress loop, which it never did before.

Tested-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170901/030b41f5/attachment-0001.htm>


More information about the libvir-list mailing list