[libvirt] [PATCH] storage: Check and possibly update config file after build

[Peter Krempa]

On Wed, Sep 06, 2017 at 15:24:18 -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1464313
> 
> As it turns out, the on-disk config file (e.g. not the stateDir file)
> needs to be updated when --override is provided since it's possible and
> highly probable that the def->source.format has been adjusted and could
> cause a future start after perhaps a libvirtd restart to have the older
> format from a define operation from the backend.
> 
> So in the 2 places where it's possible a write would be needed (create
> after define and build), let's perform a check and do the save/write
> operation on the configFile if it's necessary.

I don't think this is correct. If you use the "create" API with a custom
XML this should not in any way touch the persistent config of the pool,
similarly as we do with VMs. The provided XML may describe a completely
different storage pool and using the 'create' API should not overwrite
anything stored persistently.

If a user messes up the storage state via the live config, he needs to
fix everything by themselves.

This would just overwrite persistent config which is not desired.

NACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170911/aa5e9af5/attachment-0001.sig>