[libvirt] [PATCH] qemu: Don't report failure to destroy a destroyed domain

Martin Kletzander mkletzan at redhat.com
Mon Sep 11 12:43:07 UTC 2017


On Fri, Sep 08, 2017 at 09:25:34PM +0200, Jiri Denemark wrote:
>When destroying a domain libvirt marks it internally with a
>beingDestroyed flag to make sure the qemuDomainDestroyFlags API itself
>cleans up after the domain rather than letting an uninformed EOF handler
>do it. However, when the domain is being started at the moment libvirt
>was asked to destroy it, only the starting thread can properly clean up
>after the domain and thus it ignores the beingDestroyed flag. Once
>qemuDomainDestroyFlags finally gets a job, the domain may not be running
>anymore, which should not be reported as an error if the domain has been
>starting up.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1445600
>

Kinda hairy, but I understood it after reading the bug as well.

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170911/71013878/attachment-0001.sig>


More information about the libvir-list mailing list