[libvirt] [PATCH] virsh: delete "id" for domrename OPTIONS

Martin Kletzander mkletzan at redhat.com
Mon Sep 11 12:47:24 UTC 2017


On Mon, Sep 11, 2017 at 03:53:50AM -0400, Yanqiu Zhang wrote:
>"domrename" is used to rename an inactive domain, should not use
> id for the --domain OPTION.
>---
> tools/virsh-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

See
https://www.redhat.com/archives/libvir-list/2017-September/msg00213.html
for NACK details.

>diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
>index f235c66..84c8dcc 100644
>--- a/tools/virsh-domain.c
>+++ b/tools/virsh-domain.c
>@@ -10151,7 +10151,7 @@ static const vshCmdInfo info_domrename[] = {
> };
>
> static const vshCmdOptDef opts_domrename[] = {
>-    VIRSH_COMMON_OPT_DOMAIN_FULL,
>+    VIRSH_COMMON_OPT_DOMAIN(N_("domain name or uuid")),
>     {.name = "new-name",
>      .type = VSH_OT_DATA,
>      .flags = VSH_OFLAG_REQ,
>--
>1.8.3.1
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170911/05ee3a1c/attachment-0001.sig>


More information about the libvir-list mailing list