[libvirt] [PATCH v2] storage: Adjust expected format for Disk startup processing

[Peter Krempa]

On Mon, Sep 11, 2017 at 17:25:51 -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1464313
> 
> If a Disk pool was defined/created using XML that either didn't
> specify a specific format or specified format type='unknown', then
> restarting a pool after an initial disk backend build with overwrite
> would fail after a libvirtd restart for a non-autostarted pool.
> 
> This is because the persistent pool data is not updated during pool
> build w/ overwrite processing to have the VIR_STORAGE_POOL_DISK_DOS
> default format.
> 
> So in addition to the alteration done during disk build processing,
> alter the default expectation for disk startup to be DOS if nothing
> has been defined yet. That will either succeed if the pool had been
> successfully built previously using the default DOS format or fail
> with a message indicating the format is something else that does not
> match the expect format 'dos'.

An alternative would be to fill the default value in a similar way how
we do in the post parse callbacks for VMs

> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> 
>  v1: https://www.redhat.com/archives/libvir-list/2017-September/msg00124.html
> 
>  Changes since v1... 
> 
>    * Use a totally different methodology. Rather than updating the
>      persistent config file, alter the start processing to handle the
>      unknown setting in the persistent file properly.
> 
>  src/storage/storage_backend_disk.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

ACK, this actually makes sense. We do the same transformation when
building and when starting thus the default is honored.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170912/3385a24c/attachment-0001.sig>