[libvirt] [PATCH 4/8] travis: Split building command

Martin Kletzander mkletzan at redhat.com
Thu Sep 14 15:29:31 UTC 2017


On Thu, Sep 14, 2017 at 05:10:24PM +0200, Andrea Bolognani wrote:
>On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote:
>> > So I'm on the fence about this patch - I'd have a slight preference for
>> > existing behaviour of failing fast to keep errors at the end of the log
>>
>> I, personally, would go with:
>>
>> script:
>>  - make -j3 check
>>  - make -j3 syntax-check
>>
>> The former executes the whole build and fails on first compilation or
>> test error.  The second one has a format that's easily skippable
>> (visually) and that's not that much to scroll through.
>
>We can't run either 'make check' or 'make syntax-check' on macOS
>though, so your proposal would effectively kill all testing on that
>platform :)
>

Well, but that's changed after this patch, so technically it wouldn't ;)
Anyway, the point was keeping syntax-check last as that's easier to
visually skip.

ACK either way

>--
>Andrea Bolognani / Red Hat / Virtualization
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170914/6a1d8a5e/attachment-0001.sig>


More information about the libvir-list mailing list