[libvirt] [PATCH 2/6] conf: Add invalid secrettype checks

[Peter Krempa]

On Thu, Sep 14, 2017 at 14:03:06 -0400, John Ferlan wrote:
> Add a couple of tests to "validate" checks in domain_conf that either

The quotes seem slightly inapropriate here. If this only "validates" the
checks, then why to add it? Just validate them.

> a missing secrettype (CONFIG_UNSUPPORTED) or an mismatched secrettype
> of ceph for an iSCSI disk (INTERNAL_ERROR) will cause a parsing error.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  ...drive-network-iscsi-auth-secrettype-invalid.xml | 33 ++++++++++++++++++++++
>  ...k-drive-network-iscsi-auth-wrong-secrettype.xml | 33 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  2 ++
>  3 files changed, 68 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-secrettype-invalid.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-wrong-secrettype.xml

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170915/3d5c437c/attachment-0001.sig>