[libvirt] [PATCH 1/7] cpu_conf: Introduce virCPUDefList{Parse, Free}

Jiri Denemark jdenemar at redhat.com
Mon Sep 18 08:36:10 UTC 2017


On Fri, Sep 15, 2017 at 14:04:42 +0200, Ján Tomko wrote:
> On Thu, Sep 14, 2017 at 12:57:14PM +0200, Jiri Denemark wrote:
> >For parsing a list of CPU XMLs into a NULL-terminated list of CPU defs.
> >
> >Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> >---
> > src/conf/cpu_conf.c      | 78 ++++++++++++++++++++++++++++++++++++++++++++++++
> > src/conf/cpu_conf.h      |  7 +++++
> > src/libvirt_private.syms |  2 ++
> > 3 files changed, 87 insertions(+)
> >
> 
> [...]
> 
> >+/*
> >+ * Parses a list of CPU XMLs into a NULL-terminated list of CPU defs.
> >+ */
> >+virCPUDefPtr *
> >+virCPUDefListParse(const char **xmlCPUs,
> >+                   unsigned int ncpus,
> >+                   virCPUType cpuType)
> >+{
> >+
> 
> [...]
> 
> >+    if (ncpus < 1) {
> 
> Interesting way of spelling '== 0'

Yeah, caused by copy&paste engineering... see the next patch where the
same condition gets removed from cpuBaselineXML. Fixed.

Jirka




More information about the libvir-list mailing list