[libvirt] [PATCH] check-spacing: Don't hardcode Perl interpreter path

[Ján Tomko]

On Mon, Sep 18, 2017 at 02:39:39PM +0200, Andrea Bolognani wrote:
>This is particularly useful on operating systems that don't ship
>Perl as part of the base system (eg. FreeBSD) while still working
>just as well as it did before on Linux.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> build-aux/check-spacing.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

For the usual use case of 'make syntax-check' this should be working
already, since we run it as $(PERL) with the binary path detected
at configure time.

But this change is an improvement. ACK if you extend it to include all
perl scripts.

Jan

>diff --git a/build-aux/check-spacing.pl b/build-aux/check-spacing.pl
>index 448acf234..ca8b43491 100755
>--- a/build-aux/check-spacing.pl
>+++ b/build-aux/check-spacing.pl
>@@ -1,4 +1,4 @@
>-#!/usr/bin/perl
>+#!/usr/bin/env perl
> #
> # check-spacing.pl: Report any usage of 'function (..args..)'
> # Also check for other syntax issues, such as correct use of ';'
>-- 
>2.13.5
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170918/63fe83e5/attachment-0001.sig>