[libvirt] [PATCH 0/6] Fix guest CPU updates for inactive domains

[Michal Privoznik]

On 09/18/2017 03:35 PM, Jiri Denemark wrote:
> This series originally started as a cleanup work, but it turned out two
> real bugs got fixed with this cleanup :-)
> 
> Since commit v2.2.0-199-g7ce711a30e libvirt stores an updated guest CPU
> in domain's live definition and there's no need to update it every time
> we want to format the definition. Thus libvirt should never internally
> request a guest CPU update when formatting domain XML. But if it is
> asked by a user to do so, it should use the same host CPU model which is
> used when starting a domain to provide meaningful results.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1481309
> https://bugzilla.redhat.com/show_bug.cgi?id=1485022
> 
> Jiri Denemark (6):
>   qemuxml2xmltest: Add tests for Power CPUs
>   cpu_conf: Drop updateCPU from virCPUDefFormat
>   cpu_conf: Simplify formatting of guest CPU attributes
>   conf: Drop unused VIR_DOMAIN_DEF_FORMAT_UPDATE_CPU
>   qemu: Use correct host model for updating guest cpu
>   qemu: Don't update CPU when formatting live def
> 
>  src/bhyve/bhyve_driver.c                           |  2 +-
>  src/conf/capabilities.c                            |  2 +-
>  src/conf/cpu_conf.c                                | 38 +++++++++------------
>  src/conf/cpu_conf.h                                |  9 ++---
>  src/conf/domain_capabilities.c                     |  2 +-
>  src/conf/domain_conf.c                             |  6 +---
>  src/conf/domain_conf.h                             |  1 -
>  src/conf/snapshot_conf.c                           |  3 +-
>  src/libxl/libxl_driver.c                           |  2 +-
>  src/qemu/qemu_domain.c                             | 17 +++++++---
>  src/qemu/qemu_domain.h                             |  3 +-
>  src/qemu/qemu_driver.c                             |  9 ++++-
>  src/qemu/qemu_migration_cookie.c                   |  2 +-
>  src/test/test_driver.c                             |  2 +-
>  src/vz/vz_driver.c                                 |  2 +-
>  tests/cputest.c                                    | 15 ++++-----
>  .../ppc64-host+guest-compat-incompatible.xml       |  2 +-
>  .../ppc64-host+guest-compat-invalid.xml            |  2 +-
>  .../cputestdata/ppc64-host+guest-compat-valid.xml  |  2 +-
>  .../qemuxml2xmlout-pseries-cpu-compat-power9.xml   | 38 +++++++++++++++++++++
>  .../qemuxml2xmlout-pseries-cpu-compat.xml          | 38 +++++++++++++++++++++
>  .../qemuxml2xmlout-pseries-cpu-exact.xml           | 39 ++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  4 +++
>  23 files changed, 178 insertions(+), 62 deletions(-)
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat-power9.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-exact.xml
> 

ACK series.

Michal