[libvirt] [PATCH] check-spacing: Don't hardcode Perl interpreter path

Andrea Bolognani abologna at redhat.com
Tue Sep 19 11:13:55 UTC 2017


On Mon, 2017-09-18 at 17:11 +0200, Ján Tomko wrote:
> On Mon, Sep 18, 2017 at 02:39:39PM +0200, Andrea Bolognani wrote:
> > This is particularly useful on operating systems that don't ship
> > Perl as part of the base system (eg. FreeBSD) while still working
> > just as well as it did before on Linux.
> > 
> > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> > ---
> > build-aux/check-spacing.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> For the usual use case of 'make syntax-check' this should be working
> already, since we run it as $(PERL) with the binary path detected
> at configure time.

It does.

> But this change is an improvement. ACK if you extend it to include all
> perl scripts.

Fair enough, I failed to realize just how many more Perl scripts
were affected by the issue until you pointed it out.

I've just posted v2 which fixes all Perl scripts, and additionally
all Python scripts since they were in a similar position.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list