[libvirt] [PATCH] qemu: Mark graphics ports used on reconnect

Cole Robinson crobinso at redhat.com
Tue Sep 19 14:15:44 UTC 2017


On 09/19/2017 09:14 AM, Martin Kletzander wrote:
> On Mon, Sep 18, 2017 at 04:25:04PM +0200, Michal Privoznik wrote:
>> On 09/18/2017 04:10 PM, Cole Robinson wrote:
>>> On 09/18/2017 09:47 AM, Michal Privoznik wrote:
>>>> This is an issue that's bugging me for a long time. I don't know
>>>> exactly when and who is to blame but on daemon reconnect we lose
>>>> qemu's port allocator internal state.
>>>
>>> It's the kernel's fault, broken in 4.11+, patches recently posted
>>> upstream but not in any release yet:
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1432684
>>>
>>
>> Cool thanks. I'll keep an eye on it. Nevertheless, we should merge this
>> patch as from control POV it makes no sense to try to bind to ports we
>> know are taken.
>>
> 
> I agree on that (not that it would've been my idea to add this), but
> with changed commit message (for example keeping the last bit that has
> the same information as the reply above) I'd ACK it.  Consider that done
> unless Cole disagrees.

To clarify I wasn't disagreeing, just wanted to point out the kernel issue

Thanks,
Cole




More information about the libvir-list mailing list