[libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

Michal Privoznik mprivozn at redhat.com
Thu Sep 21 15:27:59 UTC 2017


On 09/21/2017 04:58 PM, Peter Krempa wrote:
> On Thu, Sep 21, 2017 at 16:08:05 +0200, Michal Privoznik wrote:
>> On 09/21/2017 04:01 PM, Ján Tomko wrote:
>>> On Thu, Sep 21, 2017 at 02:55:12PM +0200, Michal Privoznik wrote:
> 
> [...]
> 
>>>>
>>>
>>> ACK
>>>
>>> Looks like aiforaf in libvirt_nss.c could use the same treatment.
>>
>> I've no idea what aiforaf mean.
> 
> $ git grep aiforaf
> 
> tools/nss/libvirt_nss.c:aiforaf(const char *name, int af, struct addrinfo *pai, struct addrinfo **aip)
> tools/nss/libvirt_nss.c:        aiforaf(name, AF_INET6, ai, &cur);
> tools/nss/libvirt_nss.c:        aiforaf(name, AF_INET, ai, &cur);
> 

Ah, aiforaf(). This is why I put brackets after function names so that
it's visible what I mean. Anyway, I was wondering why I haven't hit that
memleak and it's happening only on BSDs. I'll post a patch shortly.

Michal




More information about the libvir-list mailing list