[libvirt] [PATCH] Print hex values with '0x' prefix and octal with '0' in debug messages

Kashyap Chamarthy kchamart at redhat.com
Mon Sep 25 12:20:35 UTC 2017


On Mon, Sep 25, 2017 at 11:45:51AM +0100, Daniel P. Berrange wrote:
> Seeing a log message saying 'flags=93' is ambiguous & confusing unless
> you happen to know that libvirt always prints flags as hex.  Change our
> debug messages so that they always add a '0x' prefix when printing flags,
> and '0' prefix when printing mode. A few other misc places gain a '0x'
> prefix in error messages too.

Thanks, this is useful.  I always have to pause a bit, and `grep` around
to remind myself that they're in hex.
 
[...]

> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>

FWIW: 

  Acked-by: Kashyap Chamarthy <kchamart at redhat.com>

[...]

>  131 files changed, 552 insertions(+), 552 deletions(-)

[...]


-- 
/kashyap




More information about the libvir-list mailing list