[libvirt] [PATCH python] Avoid implicit treatment of an arithmetic result as a boolean

[Pavel Hrdina]

On Tue, Sep 26, 2017 at 11:15:36AM +0100, Daniel P. Berrange wrote:
> Latest GCC versions are unhappy with us treating an integer
> arithmetic result as a boolean:
> 
> libvirt-utils.c: In function ‘virReallocN’:
> libvirt-utils.c:111:23: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context]
>      if (!tmp && (size * count)) {
>                  ~~~~~~^~~~~~~~
> 
> Add an explicit comparison '!= 0' to keep it happy, since its
> suggestion to use '&&' is nonsense.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  libvirt-utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt-utils.c b/libvirt-utils.c
> index b8ac5e9..f7b4478 100644
> --- a/libvirt-utils.c
> +++ b/libvirt-utils.c
> @@ -108,7 +108,7 @@ virReallocN(void *ptrptr,
>          return -1;
>      }
>      tmp = realloc(*(void**)ptrptr, size * count);
> -    if (!tmp && (size * count)) {
> +    if (!tmp && ((size * count) != 0)) {

There is no need for the extra set of brackets:

    if (!tmp && (size * count) != 0) {...}

but that's a matter of personal preference.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170926/59e3d3d1/attachment-0001.sig>