[libvirt] [PATCH 1/2] conf: fix formatting of udp chardev attributes

[Ján Tomko]

On Tue, Sep 26, 2017 at 01:58:52PM +0200, Ján Tomko wrote:
>It is possible (although possibly not very useful) to leave out
>the service attribute when using <source mode='bind'/>
>
>Fix the formatter bug introduced by commit 4a0da34 and format
>the host when its present (checked for non-NULL inside
>virBufferEscapeString) instead of basing it on the presence
>of the service attribute.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1455825
>---
> src/conf/domain_conf.c                              | 12 ++++--------
> tests/genericxml2xmloutdata/generic-chardev-udp.xml |  2 +-
> 2 files changed, 5 insertions(+), 9 deletions(-)
>

NACK to this one,

I have already sent it separately:
https://www.redhat.com/archives/libvir-list/2017-September/msg00921.html

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170926/13e5e8e9/attachment-0001.sig>