[libvirt] [PATCH v9 0/4] Add support for Veritas HyperScale (VxHS) block device protocol

[John Ferlan]

ping -

Would be good to close on this before freeze.  I think design has been
agreed upon and Ashish has tested.

Only patches 3 and 4 are not re-reviewed.

Tks -

John

On 09/19/2017 09:32 PM, John Ferlan wrote:
> v8: https://www.redhat.com/archives/libvir-list/2017-September/msg00375.html
> 
> Changes since v8
> 
>  * Patches 1-6 patches, everything else deals with TLS.
> 
>  * Patches 7-8 - no change, now patch 1-2.  Didn't push since they're
>                  related to these changes
> 
>  * Patch 9 - Old patch Was ACK'd, new patch is 3. Old patch11 review
>              caused me to add more fields to _virStorageSource to pepare
>              "tlsCertdir", "tlsListen", and "tlsVerify" using the cfg
>              field for certdir, but direct sets for listen and verify.
> 
>  * Patch 10 - dropped
> 
>  * Patch 11 - now patch 4. Alter the qemu_command.c and qemu_hotplug.c
>               code to use the virStorageSource fields rather than from
>               disk or cfg. Code makes more use of whether the
>               "src->haveTLS == VIR_TRISTATE_BOOL_YES" is true rather
>               then src->tlsAlias.  Added qemuDomainDelDiskSrcTLSObject.
>               Renamed/reworked the qemuDomainAddDiskSrcTLSObject.
>               Looks cleaner to me...
> 
> Ashish will post a patch separately to fix an issue found in
> qemuDomainGetTLSObjects when secAlias == NULL and the deref
> of *secAlias.
> 
> Ashish Mittal (3):
>   conf: Introduce TLS options for VxHS block device clients
>   util: Add TLS attributes to virStorageSource
>   qemu: Add TLS support for Veritas HyperScale (VxHS)
> 
> John Ferlan (1):
>   qemu: Introduce qemuDomainPrepareDiskSource
> 
>  docs/formatdomain.html.in                          | 40 ++++++++---
>  docs/schemas/domaincommon.rng                      |  5 ++
>  src/conf/domain_conf.c                             | 29 +++++++-
>  src/qemu/libvirtd_qemu.aug                         |  4 ++
>  src/qemu/qemu.conf                                 | 34 ++++++++++
>  src/qemu/qemu_block.c                              |  8 +++
>  src/qemu/qemu_command.c                            | 33 +++++++++
>  src/qemu/qemu_conf.c                               | 16 +++++
>  src/qemu/qemu_conf.h                               |  3 +
>  src/qemu/qemu_domain.c                             | 73 ++++++++++++++++++++
>  src/qemu/qemu_domain.h                             | 11 +++
>  src/qemu/qemu_hotplug.c                            | 79 ++++++++++++++++++++++
>  src/qemu/qemu_process.c                            |  4 ++
>  src/qemu/test_libvirtd_qemu.aug.in                 |  2 +
>  src/util/virstoragefile.c                          | 11 ++-
>  src/util/virstoragefile.h                          | 15 ++++
>  ...-disk-drive-network-tlsx509-multidisk-vxhs.args | 43 ++++++++++++
>  ...v-disk-drive-network-tlsx509-multidisk-vxhs.xml | 50 ++++++++++++++
>  ...muxml2argv-disk-drive-network-tlsx509-vxhs.args | 30 ++++++++
>  ...emuxml2argv-disk-drive-network-tlsx509-vxhs.xml | 32 +++++++++
>  tests/qemuxml2argvtest.c                           |  7 ++
>  ...uxml2xmlout-disk-drive-network-tlsx509-vxhs.xml | 34 ++++++++++
>  tests/qemuxml2xmltest.c                            |  1 +
>  23 files changed, 551 insertions(+), 13 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-vxhs.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-vxhs.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-tlsx509-vxhs.xml
>