[libvirt] [PATCH] nwfilter: Don't leak @val

ZhiPeng Lu lu.zhipeng at zte.com.cn
Wed Sep 27 08:53:50 UTC 2017


In virNWFilterIPAddrMapAddIPAddr the @val may be leaked.

Signed-off-by: ZhiPeng Lu <lu.zhipeng at zte.com.cn>
---
 src/conf/nwfilter_ipaddrmap.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c
index 446f3de..5242f05 100644
--- a/src/conf/nwfilter_ipaddrmap.c
+++ b/src/conf/nwfilter_ipaddrmap.c
@@ -61,7 +61,10 @@ virNWFilterIPAddrMapAddIPAddr(const char *ifname, char *addr)
         if (!val)
             goto cleanup;
         ret = virNWFilterHashTablePut(ipAddressMap, ifname, val);
-        goto cleanup;
+	 if (ret < 0) {
+	     virNWFilterVarValueFree(val);
+            goto cleanup;
+	 }
     } else {
         if (virNWFilterVarValueAddValue(val, addr) < 0)
             goto cleanup;
-- 
1.8.3.1




More information about the libvir-list mailing list