[libvirt] [PATCH v2 1/3] audit: Audit information about watchdog devices

Peter Krempa pkrempa at redhat.com
Wed Sep 27 09:17:28 UTC 2017


On Wed, Sep 27, 2017 at 11:10:31 +0200, Michal Privoznik wrote:
> On 09/27/2017 10:41 AM, Peter Krempa wrote:
> > On Wed, Sep 27, 2017 at 09:33:15 +0200, Michal Privoznik wrote:
> >> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> >> ---
> >>  src/conf/domain_audit.c  | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> >>  src/conf/domain_audit.h  |  5 +++++
> >>  src/libvirt_private.syms |  1 +
> >>  3 files changed, 52 insertions(+)
> >>
> >> diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c
> >> index 4afc22019..026fafe0c 100644
> >> --- a/src/conf/domain_audit.c
> >> +++ b/src/conf/domain_audit.c

[...]

> > 
> >> +    VIR_AUDIT(VIR_AUDIT_RECORD_RESOURCE, success,
> >> +              "virt=%s resrc=dev reason=%s %s uuid=%s %s",
> >> +              virt, reason, vmname, uuidstr, device);
> > 
> > The audit message should identify the host resource which is used by the
> > VM. I doubt that the alias is a good reference to the host device in use.
> > 
> > 
> 
> There's no host resource to report. Watchdogs are purely virtual.
> Therefore I went with the alias. But feel free to suggest a better option.

Ah, in that case NACK. We don't audit purely virtual resources.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170927/a894053f/attachment-0001.sig>


More information about the libvir-list mailing list