[libvirt] [PATCH] conf: Split out parsing of network disk source XML elements

[Ján Tomko]

On Fri, Sep 29, 2017 at 09:12:34AM -0400, John Ferlan wrote:
>
>
>On 09/29/2017 05:02 AM, Peter Krempa wrote:
>> virDomainDiskSourceParse got to the point of being an ugly spaghetti
>> mess by adding more and more stuff into it. Split out parsing of network
>> disk information into a separate function so that it stays contained.
>> ---
>> I've had this patch on a branch that makes virDomainDiskSourceParse
>> uglier, but with the recent VxHS patches I've got a merge conflict, thus
>> I'm sending it now.
>>
>> Note: this patch was generated with the "patience" diff algorithm
>>
>>
>>  src/conf/domain_conf.c | 183 ++++++++++++++++++++++++++-----------------------
>>  1 file changed, 99 insertions(+), 84 deletions(-)
>>
>
>Reviewed-by: John Ferlan <jferlan at redhat.com>
>
>Seems "safe" to me too.
>

Please don't push refactors or even pure code movement during the freeze.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170929/2af3ac89/attachment-0001.sig>