[libvirt] [PATCH 0/2] Clean up the nwfilter mess I created

John Ferlan jferlan at redhat.com
Thu Sep 28 19:26:47 UTC 2017


Silly me - touching the nwfilter code... Turns out the reverted patch
in 1/2 doesn't cover it as virNWFilterVarValueCreateSimple actually
steals @addr, so freeing it on successful return ends up being a very
bad thing as I found out with the nwfilter avocado-vt tests.

So revert that and just go with the only free on failure logic in patch2

John Ferlan (2):
  Revert "nwfilter: Fix possible segfault on sometimes consumed
    variable"
  nwfilter: Only free inetaddr on virNWFilterIPAddrMapAddIPAddr failure

 src/conf/nwfilter_ipaddrmap.c       | 9 +--------
 src/nwfilter/nwfilter_learnipaddr.c | 5 ++++-
 2 files changed, 5 insertions(+), 9 deletions(-)

-- 
2.13.5




More information about the libvir-list mailing list