[libvirt] [PATCH v5 04/10] qemu/cgroup: add /dev/sev in shared devices list

[John Ferlan]

On 04/02/2018 10:18 AM, Brijesh Singh wrote:
> QEMU uses /dev/sev device while creating the SEV guest, lets add /dev/sev
> in the list of devices allowed to be accessed by the QEMU.
> 
> Signed-off-by: Brijesh Singh <<brijesh.singh at amd.com>>
> ---
>  docs/drvqemu.html.in   | 1 +
>  src/qemu/qemu.conf     | 2 +-
>  src/qemu/qemu_cgroup.c | 2 +-
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 

You'll also need :

diff --git a/src/qemu/test_libvirtd_qemu.aug.in
b/src/qemu/test_libvirtd_qemu.aug.in
index 688e5b9fda..b94b5349c4 100644
--- a/src/qemu/test_libvirtd_qemu.aug.in
+++ b/src/qemu/test_libvirtd_qemu.aug.in
@@ -60,6 +60,7 @@ module Test_libvirtd_qemu =
     { "8" = "/dev/kqemu" }
     { "9" = "/dev/rtc" }
     { "10" = "/dev/hpet" }
+    { "11" = "/dev/sev" }
 }
 { "save_image_format" = "raw" }
 { "dump_image_format" = "raw" }


Not everyone has that augeas package installed and thus fail to run the
'check-augeas-remote'...

I think that's all that's necessary - cgroups and devices being added is
perhaps something Daniel knows a bit more about...

John

> diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in
> index cbd159d..7c33a18 100644
> --- a/docs/drvqemu.html.in
> +++ b/docs/drvqemu.html.in
> @@ -397,6 +397,7 @@ chmod o+x /path/to/directory
>  /dev/random, /dev/urandom,
>  /dev/ptmx, /dev/kvm, /dev/kqemu,
>  /dev/rtc, /dev/hpet, /dev/net/tun
> +/dev/sev
>  </pre>
>  
>      <p>
> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
> index 07eab7e..d328d96 100644
> --- a/src/qemu/qemu.conf
> +++ b/src/qemu/qemu.conf
> @@ -451,7 +451,7 @@
>  #    "/dev/null", "/dev/full", "/dev/zero",
>  #    "/dev/random", "/dev/urandom",
>  #    "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
> -#    "/dev/rtc","/dev/hpet"
> +#    "/dev/rtc","/dev/hpet", "/dev/sev"
>  #]
>  #
>  # RDMA migration requires the following extra files to be added to the list:
> diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
> index b604edb..1a271df 100644
> --- a/src/qemu/qemu_cgroup.c
> +++ b/src/qemu/qemu_cgroup.c
> @@ -46,7 +46,7 @@ const char *const defaultDeviceACL[] = {
>      "/dev/null", "/dev/full", "/dev/zero",
>      "/dev/random", "/dev/urandom",
>      "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
> -    "/dev/rtc", "/dev/hpet",
> +    "/dev/rtc", "/dev/hpet", "/dev/sev",
>      NULL,
>  };
>  #define DEVICE_PTY_MAJOR 136
>