[libvirt] [PATCH 06/11] qemu: Implement pcie-to-pci-bridge controller

John Ferlan jferlan at redhat.com
Tue Apr 3 23:13:23 UTC 2018



On 03/28/2018 10:06 AM, Andrea Bolognani wrote:
> The new controller will not yet be used automatically by
> libvirt, but at this point it's already possible to configure
> a guest to use it.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  docs/formatdomain.html.in      |  3 ++-
>  docs/schemas/domaincommon.rng  |  3 +++
>  src/conf/domain_addr.c         | 25 ++++++++++++++++++++-----
>  src/conf/domain_addr.h         |  4 +++-
>  src/conf/domain_conf.c         |  3 +++
>  src/conf/domain_conf.h         |  2 ++
>  src/qemu/qemu_command.c        |  1 +
>  src/qemu/qemu_domain.c         | 17 +++++++++++++++++
>  src/qemu/qemu_domain_address.c |  4 ++++
>  9 files changed, 55 insertions(+), 7 deletions(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 299d7b9d42..fa5a0fff8a 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -3942,7 +3942,8 @@
>        <code>pcie-root-port</code>, <code>pcie-switch-upstream-port</code> and
>        <code>pcie-switch-downstream-port</code> (<span class="since">since
>        1.2.19</span>), <code>pci-expander-bus</code> and
> -      <code>pcie-expander-bus</code> (<span class="since">since 1.3.4</span>).
> +      <code>pcie-expander-bus</code> (<span class="since">since 1.3.4</span>),
> +      <code>pcie-to-pci-bridge</code> (<span class="since">since 4.3.0</span>).
>        The root controllers (<code>pci-root</code>
>        and <code>pcie-root</code>) have an
>        optional <code>pcihole64</code> element specifying how big (in

Considering my patch 1 comments, there will be obvious adjustments here.

Is there something else perhaps a few paragraphs later that could be
added to say what this is and how/when/why someone should want to use
it? Including the restriction about slot=0 (whatever the FLA SHPC is)...
Similar to dmi-to-pci-bridge... Perhaps something that would already be
there considering my patch 1 comment for a description field or some
sort of relationship matrix...

With a few more words...

Reviewed-by: John Ferlan <jferlan at redhat.com>

John




More information about the libvir-list mailing list