[libvirt] [PATCH 3/7] remote: use a separate connection for network APIs

[Daniel P. Berrangé]

On Wed, Apr 04, 2018 at 01:45:45PM -0400, John Ferlan wrote:
> 
> 
> On 03/28/2018 11:18 AM, Daniel P. Berrangé wrote:
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/remote/remote_daemon.h          |  1 +
> >  src/remote/remote_daemon_dispatch.c | 19 +++++++++++--------
> >  src/rpc/gendispatch.pl              |  6 ++++++
> >  3 files changed, 18 insertions(+), 8 deletions(-)
> > 
> > diff --git a/src/remote/remote_daemon.h b/src/remote/remote_daemon.h
> > index 31f433c15d..60be78fe0b 100644
> > --- a/src/remote/remote_daemon.h
> > +++ b/src/remote/remote_daemon.h
> > @@ -75,6 +75,7 @@ struct daemonClientPrivate {
> >       */
> >      virConnectPtr conn;
> >      virConnectPtr interfaceConn;
> > +    virConnectPtr networkConn;
> >  
> >      daemonClientStreamPtr streams;
> >  };
> > diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
> > index 7971646c28..d0bc474850 100644
> > --- a/src/remote/remote_daemon_dispatch.c
> > +++ b/src/remote/remote_daemon_dispatch.c
> > @@ -1699,7 +1699,7 @@ remoteClientFreePrivateCallbacks(struct daemonClientPrivate *priv)
> 
> Trying to forward think - will there ever come a day when priv->conn ==
> NULL, but priv->*Conn != NULL?  The caller is gated on priv->conn...
> 
> IOW: Do we need to separate this one out a bit now

I'm not entirely sure at this time. It makes sense to push the if (conn)
check down into this method though, so I'll do that.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|