[libvirt] [dbus PATCH 5/9] Implement NetworkDefineXML method for Connect interface

Pavel Hrdina phrdina at redhat.com
Fri Apr 6 15:20:41 UTC 2018


On Fri, Apr 06, 2018 at 01:20:30PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
>  data/org.libvirt.Connect.xml |  6 ++++++
>  src/connect.c                | 29 +++++++++++++++++++++++++++++
>  test/test_connect.py         | 12 ++++++++++++
>  3 files changed, 47 insertions(+)
> 
> diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
> index 5f5c5fe..e36b7f6 100644
> --- a/data/org.libvirt.Connect.xml
> +++ b/data/org.libvirt.Connect.xml
> @@ -56,6 +56,12 @@
>        <arg name="xml" type="s" direction="in"/>
>        <arg name="network" type="o" direction="out"/>
>      </method>
> +    <method name="NetworkDefineXML">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-network.html#virNetworkDefineXML"/>
> +      <arg name="xml" type="s" direction="in"/>
> +      <arg name="network" type="o" direction="out"/>
> +    </method>
>      <method name="NetworkLookupByName">
>        <annotation name="org.gtk.GDBus.DocString"
>          value="See https://libvirt.org/html/libvirt-libvirt-network.html#virNetworkLookupByName"/>
> diff --git a/src/connect.c b/src/connect.c
> index 759b9fb..3a0e969 100644
> --- a/src/connect.c
> +++ b/src/connect.c
> @@ -358,6 +358,34 @@ virtDBusConnectNetworkCreateXML(GVariant *inArgs,
>      *outArgs = g_variant_new("(o)", path);
>  }
>  
> +static void
> +virtDBusConnectNetworkDefineXML(GVariant *inArgs,
> +                                GUnixFDList *inFDs G_GNUC_UNUSED,
> +                                const gchar *objectPath G_GNUC_UNUSED,
> +                                gpointer userData,
> +                                GVariant **outArgs,
> +                                GUnixFDList **outFDs G_GNUC_UNUSED,
> +                                GError **error)
> +{
> +    virtDBusConnect *connect = userData;
> +    g_autoptr(virNetwork) network = NULL;
> +    g_autofree gchar *path = NULL;
> +    gchar *xml;

const gchar *xml;

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180406/a6a39df2/attachment-0001.sig>


More information about the libvir-list mailing list