[libvirt] [PATCH 03/11] conf: Remove dubious code from virDomainPCIAddressSetGrow()

Andrea Bolognani abologna at redhat.com
Mon Apr 9 07:16:51 UTC 2018


On Fri, 2018-04-06 at 14:23 -0400, Laine Stump wrote:
> So it turns out that once all of your patches are applied, the error is
> the same before or after this code is removed, so I think it may not be
> executed at all.
> 
> 
> Since it doesn't solve the issue it originally was intended to solve,
> and removing it makes no functional difference, I have no problem with
> you removing it (it would be nice if we could figure out a way to log a
> more informative error than:
> 
> 
>     unsupported configuration: PCI controller at index 4 (0x04) has
> bus='0x04',
> 
>     but index must be larger than bus
> 
> 
> but that's a separate issue.)

Yeah, that would be nice indeed.

I've pushed the patch in the meantime, thanks for looking at it :)

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list