[libvirt] [PATCH v2 64/73] tests: Add tests for QEMU migration parameters
Jiri Denemark
jdenemar at redhat.com
Wed Apr 11 14:41:54 UTC 2018
This is an enhanced replacement for the original test from
qemumonitorjsontest which was dropped earlier in this series. More data
files with some real data will be added in the following patches.
Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
---
tests/Makefile.am | 12 ++
tests/qemumigparamsdata/unsupported.json | 3 +
tests/qemumigparamsdata/unsupported.reply | 7 +
tests/qemumigparamsdata/unsupported.xml | 4 +
tests/qemumigparamstest.c | 237 ++++++++++++++++++++++
5 files changed, 263 insertions(+)
create mode 100644 tests/qemumigparamsdata/unsupported.json
create mode 100644 tests/qemumigparamsdata/unsupported.reply
create mode 100644 tests/qemumigparamsdata/unsupported.xml
create mode 100644 tests/qemumigparamstest.c
diff --git a/tests/Makefile.am b/tests/Makefile.am
index a4f231d2a7..2c0d1311c2 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -124,6 +124,7 @@ EXTRA_DIST = \
qemuhotplugtestcpus \
qemuhotplugtestdevices \
qemuhotplugtestdomains \
+ qemumigparamsdata \
qemumonitorjsondata \
qemuxml2argvdata \
qemuxml2startupxmloutdata \
@@ -284,6 +285,7 @@ test_programs += qemuxml2argvtest qemuxml2xmltest \
qemumemlocktest \
qemucommandutiltest \
qemublocktest \
+ qemumigparamstest \
$(NULL)
test_helpers += qemucapsprobe
test_libraries += libqemumonitortestutils.la \
@@ -670,6 +672,15 @@ qemumemlocktest_SOURCES = \
testutilsqemu.c testutilsqemu.h \
testutils.c testutils.h
qemumemlocktest_LDADD = $(qemu_LDADDS) $(LDADDS)
+
+qemumigparamstest_SOURCES = \
+ qemumigparamstest.c \
+ testutils.c testutils.h \
+ testutilsqemu.c testutilsqemu.h \
+ $(NULL)
+qemumigparamstest_LDADD = libqemumonitortestutils.la \
+ $(qemu_LDADDS) $(LDADDS)
+
else ! WITH_QEMU
EXTRA_DIST += qemuxml2argvtest.c qemuxml2xmltest.c qemuargv2xmltest.c \
domainsnapshotxml2xmltest.c \
@@ -680,6 +691,7 @@ EXTRA_DIST += qemuxml2argvtest.c qemuxml2xmltest.c qemuargv2xmltest.c \
qemucaps2xmltest.c qemucommandutiltest.c \
qemumemlocktest.c qemucpumock.c testutilshostcpus.h \
qemublocktest.c \
+ qemumigparamstest.c \
$(QEMUMONITORTESTUTILS_SOURCES)
endif ! WITH_QEMU
diff --git a/tests/qemumigparamsdata/unsupported.json b/tests/qemumigparamsdata/unsupported.json
new file mode 100644
index 0000000000..0db3279e44
--- /dev/null
+++ b/tests/qemumigparamsdata/unsupported.json
@@ -0,0 +1,3 @@
+{
+
+}
diff --git a/tests/qemumigparamsdata/unsupported.reply b/tests/qemumigparamsdata/unsupported.reply
new file mode 100644
index 0000000000..2b88ba10c3
--- /dev/null
+++ b/tests/qemumigparamsdata/unsupported.reply
@@ -0,0 +1,7 @@
+{
+ "id": "libvirt-1",
+ "error": {
+ "class": "CommandNotFound",
+ "desc": "The command query-migrate-parameters has not been found"
+ }
+}
diff --git a/tests/qemumigparamsdata/unsupported.xml b/tests/qemumigparamsdata/unsupported.xml
new file mode 100644
index 0000000000..8aa3abefc0
--- /dev/null
+++ b/tests/qemumigparamsdata/unsupported.xml
@@ -0,0 +1,4 @@
+<test>
+ <migParams>
+ </migParams>
+</test>
diff --git a/tests/qemumigparamstest.c b/tests/qemumigparamstest.c
new file mode 100644
index 0000000000..4cc27bcf52
--- /dev/null
+++ b/tests/qemumigparamstest.c
@@ -0,0 +1,237 @@
+/*
+ * Copyright (C) 2011-2013 Red Hat, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include <config.h>
+
+#include "virjson.h"
+#include "virbuffer.h"
+#include "virxml.h"
+#include "testutils.h"
+#include "testutilsqemu.h"
+#include "qemumonitortestutils.h"
+#include "qemu/qemu_migration_params.h"
+#include "qemu/qemu_migration_paramspriv.h"
+#include "qemu/qemu_monitor.h"
+
+#define VIR_FROM_THIS VIR_FROM_NONE
+
+typedef struct _qemuMigParamsData qemuMigParamsData;
+struct _qemuMigParamsData {
+ virDomainXMLOptionPtr xmlopt;
+ const char *name;
+};
+
+
+static void
+qemuMigParamsTestFormatXML(virBufferPtr buf,
+ qemuMigrationParamsPtr migParams)
+{
+ virBufferAddLit(buf, "<test>\n");
+ virBufferAdjustIndent(buf, 2);
+
+ if (migParams)
+ qemuMigrationParamsFormat(buf, migParams);
+
+ virBufferAdjustIndent(buf, -2);
+ virBufferAddLit(buf, "</test>\n");
+}
+
+
+static int
+qemuMigParamsTestXML2XML(const void *opaque)
+{
+ const qemuMigParamsData *data = opaque;
+ virBuffer buf = VIR_BUFFER_INITIALIZER;
+ char *xmlFile = NULL;
+ xmlDocPtr doc = NULL;
+ xmlXPathContextPtr ctxt = NULL;
+ qemuMigrationParamsPtr migParams = NULL;
+ char *actualXML = NULL;
+ int ret = -1;
+
+ if (virAsprintf(&xmlFile, "%s/qemumigparamsdata/%s.xml",
+ abs_srcdir, data->name) < 0)
+ goto cleanup;
+
+ if (!(doc = virXMLParseFileCtxt(xmlFile, &ctxt)))
+ goto cleanup;
+
+ if (qemuMigrationParamsParse(ctxt, &migParams) < 0)
+ goto cleanup;
+
+ qemuMigParamsTestFormatXML(&buf, migParams);
+
+ if (!(actualXML = virBufferContentAndReset(&buf)))
+ goto cleanup;
+
+ if (virTestCompareToFile(actualXML, xmlFile) < 0)
+ goto cleanup;
+
+ ret = 0;
+
+ cleanup:
+ VIR_FREE(xmlFile);
+ VIR_FREE(actualXML);
+ qemuMigrationParamsFree(migParams);
+ virBufferFreeAndReset(&buf);
+ xmlXPathFreeContext(ctxt);
+ xmlFreeDoc(doc);
+ return ret;
+}
+
+
+static int
+qemuMigParamsTestXML(const void *opaque)
+{
+ const qemuMigParamsData *data = opaque;
+ virBuffer buf = VIR_BUFFER_INITIALIZER;
+ char *replyFile = NULL;
+ char *xmlFile = NULL;
+ qemuMonitorTestPtr mon = NULL;
+ virJSONValuePtr params = NULL;
+ qemuMigrationParamsPtr migParams = NULL;
+ char *actualXML = NULL;
+ int ret = -1;
+
+ if (virAsprintf(&replyFile, "%s/qemumigparamsdata/%s.reply",
+ abs_srcdir, data->name) < 0 ||
+ virAsprintf(&xmlFile, "%s/qemumigparamsdata/%s.xml",
+ abs_srcdir, data->name) < 0)
+ goto cleanup;
+
+ if (!(mon = qemuMonitorTestNewFromFile(replyFile, data->xmlopt, true)))
+ goto cleanup;
+
+ if (qemuMonitorGetMigrationParams(qemuMonitorTestGetMonitor(mon),
+ ¶ms) < 0)
+ goto cleanup;
+
+ if (!(migParams = qemuMigrationParamsFromJSON(params)))
+ goto cleanup;
+
+ qemuMigParamsTestFormatXML(&buf, migParams);
+
+ if (!(actualXML = virBufferContentAndReset(&buf)))
+ goto cleanup;
+
+ if (virTestCompareToFile(actualXML, xmlFile) < 0)
+ goto cleanup;
+
+ ret = 0;
+
+ cleanup:
+ VIR_FREE(replyFile);
+ VIR_FREE(xmlFile);
+ VIR_FREE(actualXML);
+ virJSONValueFree(params);
+ qemuMigrationParamsFree(migParams);
+ virBufferFreeAndReset(&buf);
+ qemuMonitorTestFree(mon);
+ return ret;
+}
+
+
+static int
+qemuMigParamsTestJSON(const void *opaque)
+{
+ const qemuMigParamsData *data = opaque;
+ char *replyFile = NULL;
+ char *jsonFile = NULL;
+ qemuMonitorTestPtr mon = NULL;
+ virJSONValuePtr paramsIn = NULL;
+ virJSONValuePtr paramsOut = NULL;
+ qemuMigrationParamsPtr migParams = NULL;
+ char *actualJSON = NULL;
+ int ret = -1;
+
+ if (virAsprintf(&replyFile, "%s/qemumigparamsdata/%s.reply",
+ abs_srcdir, data->name) < 0 ||
+ virAsprintf(&jsonFile, "%s/qemumigparamsdata/%s.json",
+ abs_srcdir, data->name) < 0)
+ goto cleanup;
+
+ if (!(mon = qemuMonitorTestNewFromFile(replyFile, data->xmlopt, true)))
+ goto cleanup;
+
+ if (qemuMonitorGetMigrationParams(qemuMonitorTestGetMonitor(mon),
+ ¶msIn) < 0)
+ goto cleanup;
+
+ if (!(migParams = qemuMigrationParamsFromJSON(paramsIn)))
+ goto cleanup;
+
+ if (!(paramsOut = qemuMigrationParamsToJSON(migParams)) ||
+ !(actualJSON = virJSONValueToString(paramsOut, true)))
+ goto cleanup;
+
+ if (virTestCompareToFile(actualJSON, jsonFile) < 0)
+ goto cleanup;
+
+ ret = 0;
+
+ cleanup:
+ VIR_FREE(replyFile);
+ VIR_FREE(jsonFile);
+ VIR_FREE(actualJSON);
+ virJSONValueFree(paramsIn);
+ virJSONValueFree(paramsOut);
+ qemuMigrationParamsFree(migParams);
+ qemuMonitorTestFree(mon);
+ return ret;
+}
+
+
+static int
+mymain(void)
+{
+ virQEMUDriver driver;
+ int ret = 0;
+
+#if !WITH_YAJL
+ fputs("libvirt not compiled with yajl, skipping this test\n", stderr);
+ return EXIT_AM_SKIP;
+#endif
+
+ if (virThreadInitialize() < 0 ||
+ qemuTestDriverInit(&driver) < 0)
+ return EXIT_FAILURE;
+
+ virEventRegisterDefaultImpl();
+
+#define DO_TEST(name) \
+ do { \
+ qemuMigParamsData data = { \
+ driver.xmlopt, name \
+ }; \
+ if (virTestRun(name " (xml)", qemuMigParamsTestXML, &data) < 0) \
+ ret = -1; \
+ if (virTestRun(name " (json)", qemuMigParamsTestJSON, &data) < 0) \
+ ret = -1; \
+ if (virTestRun(name " (xml2xml)", qemuMigParamsTestXML2XML, &data) < 0) \
+ ret = -1; \
+ } while (0)
+
+ DO_TEST("unsupported");
+
+ qemuTestDriverFree(&driver);
+
+ return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
+}
+
+VIR_TEST_MAIN(mymain)
--
2.17.0
More information about the libvir-list
mailing list