[libvirt] [libvirt PATCH v2 11/44] Deprecate QEMU_CAPS_NO_USER_CONFIG

Andrea Bolognani abologna at redhat.com
Thu Apr 12 08:07:50 UTC 2018


On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
> Implied by QEMU >= 1.2.0.
> 
> Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used
> when QEMU_CAPS_NO_USER_CONFIG is unsupported.

Is there a specific reason for the 6-patch gap between dropping
NO_USER_CONFIG and dropping NODEFCONFIG? It would IMHO make more
sense to drop them one immediately after the other.

[...]
> diff --git a/tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.args b/tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.args
> index 21a3f591df..92da7122a6 100644
> --- a/tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.args
> +++ b/tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.args
> @@ -13,7 +13,7 @@ QEMU_AUDIO_DRV=none \
>  -smp 1,sockets=1,cores=1,threads=1 \
>  -uuid 496d7ea8-9739-544b-4ebd-ef08be936e8b \
>  -nographic \
> --nodefconfig \
> +-no-user-config \
>  -nodefaults \
>  -chardev socket,id=charmonitor,\
>  path=/tmp/lib/domain--1-aarch64test/monitor.sock,server,nowait \
> 
> [ ... etc ... ]

Unsurprisingly, aarch64-traditional-pci.args needs to be refreshed
this time as well :)

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list