[libvirt] [libvirt PATCH v2 10/44] Deprecate QEMU_CAPS_MONITOR_JSON

[Ján Tomko]

On Thu, Apr 12, 2018 at 09:45:48AM +0200, Andrea Bolognani wrote:
>On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
>> We require QEMU >= 0.15.0, assume every QEMU supports it.
>
>s/0.15.0/1.5.0/
>
>Unless the usable monitor was introduced in 0.15.0, in which case
>your version is more precise.
>
>> Sadly that does not let us trivially drop qemuMonitor's
>> priv->monJSON bool, because of qemuDomainQemuAttach.
>
>I'm perfectly fine with dropping that being a follow-up patch,
>just like the one taking care of qemuCaps->usedQMP. But just so
>we're on the same page, you're planning on doing that, right?
>

Here, 'trivially' does not mean too many changes, but either
we still will need to track 'broken' domains created via QemuAttach
somehow, in case someone would try to use JSON monitor functions
with them, or drop QemuAttach completely since it's really out of date.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180412/bfd19982/attachment-0001.sig>