[libvirt] [PATCH libvirt v2 0/9] Fix virConnectRegisterCloseCallback and get rid of global variables

Marc Hartmayer mhartmay at linux.vnet.ibm.com
Thu Apr 12 12:40:55 UTC 2018


The first part of this patch series fixes the behavior of
virConnectRegisterCloseCallback and converts the testDriver to
virObjectLockable.

The subsequent patches remove the need to have the global variables
'qemuProgram' and 'remoteProgram' in libvirtd.[ch]. They only work in
combination with the fixed behavior of virConnectRegisterCloseCallback.

Changelog:
 + v1->v2:
   - Removed accepted patches
   - Removed NACKed patches
   - Added r-b to patch 5
   - Worked in comments
   - Rebased
   - Added patches 7-9 

Marc Hartmayer (9):
  virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no
    connectRegisterCloseCallback
  test: Convert testDriver to virObjectLockable
  remote: Add the information which program has to be used to
    daemonClientEventCallback
  remote: Use domainClientEventCallbacks for
    remoteReplayConnectionClosedEvent
  rpc: Introduce virNetServerGetProgramLocked helper function
  remote/rpc: Use virNetServerGetProgram() to determine the program
  rpc: use the return value of virObjectRef directly
  remote: remove ATTRIBUTE_UNUSED when attribute is actually used
  remote: shrink the critical sections

 src/libvirt-host.c                  |  10 +-
 src/libvirt_remote.syms             |   1 +
 src/remote/remote_daemon.c          |   4 +-
 src/remote/remote_daemon.h          |   3 -
 src/remote/remote_daemon_dispatch.c | 264 +++++++++++++++++++++++-------------
 src/rpc/gendispatch.pl              |   6 +
 src/rpc/virnetserver.c              |  57 ++++++--
 src/rpc/virnetserver.h              |   2 +
 src/test/test_driver.c              | 200 ++++++++++++---------------
 9 files changed, 328 insertions(+), 219 deletions(-)

-- 
2.13.4




More information about the libvir-list mailing list