[libvirt] [libvirt PATCH v2 11/44] Deprecate QEMU_CAPS_NO_USER_CONFIG

Ján Tomko jtomko at redhat.com
Thu Apr 12 15:16:31 UTC 2018


On Thu, Apr 12, 2018 at 10:07:50AM +0200, Andrea Bolognani wrote:
>On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
>> Implied by QEMU >= 1.2.0.
>>
>> Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used
>> when QEMU_CAPS_NO_USER_CONFIG is unsupported.
>
>Is there a specific reason for the 6-patch gap between dropping
>NO_USER_CONFIG and dropping NODEFCONFIG? It would IMHO make more
>sense to drop them one immediately after the other.
>

I originally wrote them in the order they apper in
virQEMUCapsInitQMPBasic, then relized inserting -nodefconfig everywhere
just to replace it with -no-user-config later is pointless and moved it
right after the first patch that touched all the test files
(QEMU_CAPS_MONITOR_JSON)

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180412/ffa5dacb/attachment-0001.sig>


More information about the libvir-list mailing list