[libvirt] [libvirt PATCH v2 11/44] Deprecate QEMU_CAPS_NO_USER_CONFIG

[Andrea Bolognani]

On Thu, 2018-04-12 at 17:16 +0200, Ján Tomko wrote:
> On Thu, Apr 12, 2018 at 10:07:50AM +0200, Andrea Bolognani wrote:
> > On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
> > > Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used
> > > when QEMU_CAPS_NO_USER_CONFIG is unsupported.
> > 
> > Is there a specific reason for the 6-patch gap between dropping
> > NO_USER_CONFIG and dropping NODEFCONFIG? It would IMHO make more
> > sense to drop them one immediately after the other.
> 
> I originally wrote them in the order they apper in
> virQEMUCapsInitQMPBasic, then relized inserting -nodefconfig everywhere
> just to replace it with -no-user-config later is pointless and moved it
> right after the first patch that touched all the test files
> (QEMU_CAPS_MONITOR_JSON)

So IIUC you would be okay with dropping NODEFCONFIG right after
NO_USER_CONFIG, correct? I would prefer that order - though I
realize I haven't ACKed the other patch yet :)

-- 
Andrea Bolognani / Red Hat / Virtualization