[libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

Andrea Bolognani abologna at redhat.com
Fri Apr 13 13:40:49 UTC 2018


On Fri, 2018-04-13 at 14:25 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 13, 2018 at 03:05:10PM +0200, Andrea Bolognani wrote:
> > No, wait, actually its native variant is, but the same is true for
> > the Adwaita icon theme. Weird. I don't see how we would need one of
> > them to be native and the other to be MinGW, they should match.
> 
> I think that highcolor line is obsolete cruft leftover when when
> we added dep on mingw32 adwaita theme.

I just tried and it looks like neither mingw*-adwaita-* nor
mingw*-hicolor-* seems to be required to build virt-viewer,
actually. I think we can safely avoid listing them altogether.

> > Please keep in mind the Ansible part is by design not tightly tied
> > to the Jenkins part, and must be usable entirely on its own for
> > development and debugging purposes.
> 
> If we really need that, then it would be better if we expressed
> dependancies between the project vars files explicitly, rather
> than duplicating information many times over

Yeah, projects depending on each other would be neat. Until that's
in place, implicit dependencies will do.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list