[libvirt] [PATCH 9/9] cfg.mk: Introduce syntax-check rule to prefer VIR_CLASS_NEW

Erik Skultety eskultet at redhat.com
Mon Apr 16 10:07:05 UTC 2018


On Fri, Apr 13, 2018 at 04:47:16PM +0200, Michal Privoznik wrote:
> Now that we have macro that does some checks lets forbid raw
> usage of virClassNew() in favor of VIR_CLASS_NEW().
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  cfg.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/cfg.mk b/cfg.mk
> index 4078bc2c63..5b7a9728d2 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -321,6 +321,11 @@ sc_prohibit_internal_functions:
>  	halt='use VIR_ macros instead of internal functions' \
>  	  $(_sc_search_regexp)
>
> +sc_prohibit_raw_virclassnew:
> +	@prohibit='virClassNew *\(' \
> +	halt='use VIR_CLASS_NEW macro instead of virClassNew' \

s/macro//

Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list