[libvirt] [PATCH v2 68/73] qemu: Properly avoid cancelling memory-only dump

Ján Tomko jtomko at redhat.com
Mon Apr 16 18:51:10 UTC 2018


On Wed, Apr 11, 2018 at 04:41:58PM +0200, Jiri Denemark wrote:
>migrate_cancel QMP command cannot be used for cancelling memory-only
>dumps and priv->job.dump_memory_only is used for reporting an error if
>someone calls virDomainAbortJob when memory-only dump job is running.
>
>Since commit 150930e3098 the dump_memory_only flag is set only
>dump-guest-memory command was called without the detach parameter. This

s/only/only if/

>would incorrectly allow libvirt to send migrate_cancel while the
>detached memory-only dump is running.
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> src/qemu/qemu_driver.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180416/ced17782/attachment-0001.sig>


More information about the libvir-list mailing list