[libvirt] [PATCH] tests: Don't touch /dev/vhost-net in qemuxml2argvtest

Martin Kletzander mkletzan at redhat.com
Tue Apr 17 11:44:53 UTC 2018


On Tue, Apr 17, 2018 at 12:44:13PM +0200, Ján Tomko wrote:
>On Tue, Apr 17, 2018 at 11:30:06AM +0200, Martin Kletzander wrote:
>>The code is trying to open /dev/vhost-net from the host machine and if the
>>current user has access to it, the command line will end up having two more
>>options for an interface (,vhost=on,vhostfd=X where X is next free file
>>descriptor).
>>
>
>Alternate proposal which mocks qemuInterfaceOpenVhostNet instead of
>doing this per-path:
>https://www.redhat.com/archives/libvir-list/2018-April/msg01433.html
>(Even if we start testing the custom path to the vhost-net device,
>we don't want to access the host)
>

Sure, I've no preference.

>Jano
>
>>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>>---
>> tests/qemuxml2argvmock.c | 36 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180417/96374bd4/attachment-0001.sig>


More information about the libvir-list mailing list