[libvirt] [dbus PATCH 04/25] Implement BlockPeek metohd for Domain Interface

[Ján Tomko]

On Tue, Apr 17, 2018 at 02:04:23PM +0200, Katerina Koukiou wrote:
>Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
>---
> data/org.libvirt.Domain.xml |  9 +++++++++
> src/domain.c                | 39 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 48 insertions(+)
>
>diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
>index 48b8a95..85e2cf6 100644
>--- a/data/org.libvirt.Domain.xml
>+++ b/data/org.libvirt.Domain.xml
>@@ -54,6 +54,15 @@
>       <arg name="xml" type="s" direction="in"/>
>       <arg name="flags" type="u" direction="in"/>
>     </method>
>+    <method name="BlockPeek">
>+      <annotation name="org.gtk.GDBus.DocString"
>+        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainCreateWithFlags"/>

https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainBlockPeek

>+      <arg name="disk" type="s" direction="in"/>
>+      <arg name="offset" type="t" direction="in"/>
>+      <arg name="size" type="u" direction="in"/>

Even though size_t is (usually) 64 bits, unsigned should be enough given
the documented RPC limits.

>+      <arg name="flags" type="u" direction="in"/>
>+      <arg name="buffer" type="ay" direction="out"/>
>+    </method>
>     <method name="Create">
>       <annotation name="org.gtk.GDBus.DocString"
>         value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainCreateWithFlags"/>

With the doc link fixed:

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180417/74703018/attachment-0001.sig>