[libvirt] [PATCH 2/7] remote: Fix usage of ATTRIBUTE_FALLTHROUGH

John Ferlan jferlan at redhat.com
Tue Apr 17 16:22:13 UTC 2018


Move to within the #if since the #else portion ends with a goto
and that raised concern by Coverity.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/remote/remote_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index d3b588c374..12f7d47388 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -928,6 +928,7 @@ doRemoteOpen(virConnectPtr conn,
         if (!priv->tls)
             goto failed;
         priv->is_secure = 1;
+        ATTRIBUTE_FALLTHROUGH;
 #else
         (void)tls_priority;
         (void)sanity;
@@ -937,7 +938,6 @@ doRemoteOpen(virConnectPtr conn,
         goto failed;
 #endif
 
-        ATTRIBUTE_FALLTHROUGH;
     case trans_tcp:
         priv->client = virNetClientNewTCP(priv->hostname, port, AF_UNSPEC);
         if (!priv->client)
-- 
2.13.6




More information about the libvir-list mailing list