[libvirt] [dbus PATCH 10/25] Implement BlockRebase method for Domain Interface

[Pavel Hrdina]

On Tue, Apr 17, 2018 at 02:04:29PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
>  data/org.libvirt.Domain.xml |  8 ++++++++
>  src/domain.c                | 29 +++++++++++++++++++++++++++++
>  2 files changed, 37 insertions(+)
> 
> diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
> index 46a6632..f5c7fb0 100644
> --- a/data/org.libvirt.Domain.xml
> +++ b/data/org.libvirt.Domain.xml
> @@ -91,6 +91,14 @@
>        <arg name="bandwidth" type="t" direction="in"/>
>        <arg name="flags" type="u" direction="in"/>
>      </method>
> +    <method name="BlockRebase">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainBlockRebase"/>
> +      <arg name="disk" type="s" direction="in"/>
> +      <arg name="base" type="s" direction="in"/>
> +      <arg name="bandwidth" type="t" direction="in"/>
> +      <arg name="flags" type="u" direction="in"/>
> +    </method>
>      <method name="Create">
>        <annotation name="org.gtk.GDBus.DocString"
>          value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainCreateWithFlags"/>
> diff --git a/src/domain.c b/src/domain.c
> index af8cc73..107355e 100644
> --- a/src/domain.c
> +++ b/src/domain.c
> @@ -521,6 +521,34 @@ virtDBusDomainBlockPull(GVariant *inArgs,
>          virtDBusUtilSetLastVirtError(error);
>  }
>  
> +static void
> +virtDBusDomainBlockRebase(GVariant *inArgs,
> +                          GUnixFDList *inFDs G_GNUC_UNUSED,
> +                          const gchar *objectPath,
> +                          gpointer userData,
> +                          GVariant **outArgs G_GNUC_UNUSED,
> +                          GUnixFDList **outFDs G_GNUC_UNUSED,
> +                          GError **error)
> +{
> +    virtDBusConnect *connect = userData;
> +    g_autoptr(virDomain) domain = NULL;
> +    const gchar *disk;
> +    const gchar *base;
> +    gulong bandwidth;
> +    guint flags;
> +
> +    g_variant_get(inArgs, "(&s&stu)", &disk, &base, &bandwidth, &flags);
> +    if (g_strcmp0(base, "") == 0)

You can use g_str_equal().

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180417/d303ec17/attachment-0001.sig>