[libvirt] [dbus PATCH 16/25] Implement FSTrim method for Domain Interface

[Pavel Hrdina]

On Tue, Apr 17, 2018 at 02:04:35PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
>  data/org.libvirt.Domain.xml |  7 +++++++
>  src/domain.c                | 28 ++++++++++++++++++++++++++++
>  2 files changed, 35 insertions(+)
> 
> diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
> index 367bc00..6d4ffa5 100644
> --- a/data/org.libvirt.Domain.xml
> +++ b/data/org.libvirt.Domain.xml
> @@ -149,6 +149,13 @@
>        <arg name="flags" type="u" direction="in"/>
>        <arg name="thawdFilesystems" type="u" direction="out"/>
>      </method>
> +    <method name="FSTrim">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSTrim"/>
> +      <arg name="mountpoint" type="s" direction="in"/>
> +      <arg name="minimum" type="t" direction="in"/>
> +      <arg name="flags" type="u" direction="in"/>
> +    </method>
>      <method name="GetBlkioParameters">
>        <annotation name="org.gtk.GDBus.DocString"
>          value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetBlkioParameters"/>
> diff --git a/src/domain.c b/src/domain.c
> index a0feea9..f0e7f28 100644
> --- a/src/domain.c
> +++ b/src/domain.c
> @@ -771,6 +771,33 @@ virtDBusDomainFSThaw(GVariant *inArgs,
>      *outArgs = g_variant_new("(u)", ret);
>  }
>  
> +static void
> +virtDBusDomainFSTrim(GVariant *inArgs,
> +                     GUnixFDList *inFDs G_GNUC_UNUSED,
> +                     const gchar *objectPath,
> +                     gpointer userData,
> +                     GVariant **outArgs G_GNUC_UNUSED,
> +                     GUnixFDList **outFDs G_GNUC_UNUSED,
> +                     GError **error)
> +{
> +    virtDBusConnect *connect = userData;
> +    g_autoptr(virDomain) domain = NULL;
> +    const gchar *mountpoint;
> +    gulong minimum;
> +    guint flags;
> +
> +    g_variant_get(inArgs, "(stu)", &mountpoint, &minimum, &flags);
> +    if (g_strcmp0(mountpoint, "") == 0)

You can use g_str_equal() here, at this point mountpoint will be always
allocated.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180418/68ee20ea/attachment-0001.sig>