[libvirt] [PATCH 1/2] virmocklibxl.c: Fix include of virfile.h

Michal Privoznik mprivozn at redhat.com
Wed Apr 18 08:04:41 UTC 2018


Firstly, this isn't supposed to be in angle brackets because it's
not a system header file (not that gcc distinguishes these two,
it's just guide for us developers).

Secondly, no need to use util/ path prefix because CFLAGS already
contain -I$(srcdir)/util.

The include is needed because virmocklibxl is mocking
virFileMakePath() and even when VIR_MOCK_IMPL_RET_ARGS() does
forward declaration to shut up compiler we need real
virFileMakePath() declaration so that when it changes compiler
catches mismatching declarations.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tests/virmocklibxl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/virmocklibxl.c b/tests/virmocklibxl.c
index 50ae25810f..546c6d6a43 100644
--- a/tests/virmocklibxl.c
+++ b/tests/virmocklibxl.c
@@ -27,11 +27,12 @@
 # include <sys/stat.h>
 # include <unistd.h>
 # include <libxl.h>
-# include <util/virfile.h>
 # include <xenstore.h>
 # include <xenctrl.h>
 # include <sys/socket.h>
 
+# include "virfile.h"
+
 VIR_MOCK_IMPL_RET_VOID(xs_daemon_open,
                        struct xs_handle *)
 {
-- 
2.16.1




More information about the libvir-list mailing list