[libvirt] [dbus PATCH 18/25] Implement PinEmulator method for Domain Interface

[Pavel Hrdina]

On Tue, Apr 17, 2018 at 02:04:37PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
>  data/org.libvirt.Domain.xml |  6 ++++++
>  src/domain.c                | 34 ++++++++++++++++++++++++++++++++++
>  2 files changed, 40 insertions(+)
> 
> diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
> index f2ef3dd..97c5471 100644
> --- a/data/org.libvirt.Domain.xml
> +++ b/data/org.libvirt.Domain.xml
> @@ -268,6 +268,12 @@
>          value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateStartPostCopy"/>
>        <arg name="flags" type="u" direction="in"/>
>      </method>
> +    <method name="PinEmulator">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainPinEmulator"/>
> +      <arg name="cpumap" type="ay" direction="in"/>

We need to figure out a better way how to represent the CPU map in
libvirt-dbus.  IMHO using an array of unsigned char is not the best
from for D-Bus.

There are two possible forms, using the string representation as we
have in virsh, so for example "0,3-7,^5" which is 10011011.

The second form is the one that libvirt-python uses, a tuple of boolean
values, which in case of D-Bus would be represented as array of boolean
values.

The first form is better suited for humans so I guess we should go with
the second form in D-Bus.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180418/53532189/attachment-0001.sig>