[libvirt] [PATCH] git: add config file telling git-publish how to send patches

Martin Kletzander mkletzan at redhat.com
Thu Apr 19 16:11:20 UTC 2018


On Thu, Apr 19, 2018 at 10:06:45AM +0100, Daniel P. Berrangé wrote:
>On Thu, Apr 19, 2018 at 10:55:01AM +0200, Peter Krempa wrote:
>> On Wed, Apr 18, 2018 at 18:35:18 +0100, Daniel Berrange wrote:
>> > The "git-publish" tool is a useful git extension for sending patch
>> > series for code review. It automatically creates versioned tags
>> > each time code on a branch is sent, so that there is a record of
>> > each version. It also remembers the cover letter so it does not
>> > need re-entering each time the series is reposted.
>> >
>> > With this config file present it is now sufficient[1] to run
>> >
>> >   $ git publish
>> >
>> > to send all patches in a branch to the list for review
>> >
>> > [1] Assuming your $HOME/.gitconfig has an SMTP server listed
>> > at least e.g.
>> >
>> >    [sendemail]
>> >         smtpserver = smtp.example.com
>> >
>> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>> > ---
>> >  .gitpublish | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >  create mode 100644 .gitpublish
>> >
>> > diff --git a/.gitpublish b/.gitpublish
>> > new file mode 100644
>> > index 0000000000..857f0d552c
>> > --- /dev/null
>> > +++ b/.gitpublish
>> > @@ -0,0 +1,3 @@
>> > +[gitpublishprofile "default"]
>> > +base = master
>> > +to = libvir-list at redhat.com
>>
>> ACK
>>
>> As a side-question. Does git-publish have the option to send GPG-signed
>> mails? I always wanted that, but not enough to hack it into
>> git-send-email.
>
>Not that I'm aware of. The only common use of GPG is for signing tags
>associated with pull requests.  eg when you do  git publish --pull,
>it will create a signed tag for that pull request. We don't use the
>submaintainer model though so that's not really relevant to us.
>
>Stefan takes features requests / patches on github/stefanha/git-publish
>though :-)
>

Yeah, I always wondered how to do it nicely.  I have signed commits turned on,
but if I take a commit that is even verified by github, (and looks great with
`git show --show-signature`), I have no way how to send them using send-email so
that the signing is preserved.  Would be nice to know if there's a way.

>Regards,
>Daniel
>-- 
>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180419/848193f7/attachment-0001.sig>


More information about the libvir-list mailing list