[libvirt] [PATCH 4/3] tests: Make sure rom.file='' for PCI devices keeps working

Peter Krempa pkrempa at redhat.com
Mon Apr 23 12:43:37 UTC 2018


On Mon, Apr 23, 2018 at 13:54:34 +0200, Andrea Bolognani wrote:
> Even though we just introduced the rom.enabled attribute to
> properly cover the use case, there might be guests out there
> that use the only previously available way of disabling PCI
> ROM loading by not opting in to schema validation.
> 
> To make sure such guests will keep working going forward,
> introduce a test case covering the legacy workaround.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  .../qemuxml2argvdata/pci-rom-disabled-invalid.args |  1 +
>  .../qemuxml2argvdata/pci-rom-disabled-invalid.xml  | 25 +++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  1 +
>  .../pci-rom-disabled-invalid.xml                   | 29 ++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  1 +
>  5 files changed, 57 insertions(+)
>  create mode 120000 tests/qemuxml2argvdata/pci-rom-disabled-invalid.args
>  create mode 100644 tests/qemuxml2argvdata/pci-rom-disabled-invalid.xml
>  create mode 100644 tests/qemuxml2xmloutdata/pci-rom-disabled-invalid.xml

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180423/d4a845fe/attachment-0001.sig>


More information about the libvir-list mailing list