[libvirt] [PATCH 01/29] admin: Add spaces after casts

Martin Kletzander mkletzan at redhat.com
Mon Apr 23 13:19:10 UTC 2018


On Mon, Apr 23, 2018 at 02:52:01PM +0200, Peter Krempa wrote:
>On Mon, Apr 23, 2018 at 14:44:29 +0200, Martin Kletzander wrote:
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  src/admin/admin_remote.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/admin/admin_remote.c b/src/admin/admin_remote.c
>> index b29d109f6a29..56c2e743e45b 100644
>> --- a/src/admin/admin_remote.c
>> +++ b/src/admin/admin_remote.c
>> @@ -172,8 +172,8 @@ remoteAdminConnectOpen(virAdmConnectPtr conn, unsigned int flags)
>>                                   virObjectFreeCallback);
>>
>>      if (call(conn, 0, ADMIN_PROC_CONNECT_OPEN,
>> -             (xdrproc_t)xdr_admin_connect_open_args, (char *)&args,
>> -             (xdrproc_t)xdr_void, (char *)NULL) == -1) {
>> +             (xdrproc_t)xdr_admin_connect_open_args, (char *) &args,
>> +             (xdrproc_t)xdr_void, (char *) NULL) == -1) {
>
>                ^^^^^^^^^^^ This also looks like a cast ;)
>

Oh shoot, it does.  And a freakin' obvious one indeed.  I remember adding
anything that ends with '_t' to the list of types that we cast, so I must've
left it somwhere.  I'll dig up the differences, add it here, resend the series
and then get nacked by jtomko, I guess.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180423/d7420c35/attachment-0001.sig>


More information about the libvir-list mailing list