[libvirt] [PATCH] qemu: Add I/O thread support info into domain capabilities

Martin Kletzander mkletzan at redhat.com
Tue Apr 24 11:46:05 UTC 2018


On Tue, Apr 24, 2018 at 01:03:46PM +0200, Michal Privoznik wrote:
>On 04/23/2018 04:50 PM, Martin Kletzander wrote:
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  docs/schemas/domaincaps.rng                           |  9 +++++++++
>>  src/conf/domain_capabilities.c                        |  3 +++
>>  src/conf/domain_capabilities.h                        |  1 +
>>  src/qemu/qemu_capabilities.c                          | 11 +++++++++++
>>  .../domaincapsschemadata/qemu_2.12.0-virt.aarch64.xml |  1 +
>>  tests/domaincapsschemadata/qemu_2.12.0.ppc64.xml      |  1 +
>>  tests/domaincapsschemadata/qemu_2.12.0.s390x.xml      |  1 +
>>  tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml     |  1 +
>>  .../domaincapsschemadata/qemu_2.6.0-virt.aarch64.xml  |  1 +
>>  tests/domaincapsschemadata/qemu_2.6.0.aarch64.xml     |  1 +
>>  tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml       |  1 +
>>  tests/domaincapsschemadata/qemu_2.6.0.x86_64.xml      |  1 +
>>  tests/domaincapsschemadata/qemu_2.7.0.s390x.xml       |  1 +
>>  tests/domaincapsschemadata/qemu_2.8.0-tcg.x86_64.xml  |  1 +
>>  tests/domaincapsschemadata/qemu_2.8.0.s390x.xml       |  1 +
>>  tests/domaincapsschemadata/qemu_2.8.0.x86_64.xml      |  1 +
>>  tests/domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml  |  1 +
>>  tests/domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml  |  1 +
>>  tests/domaincapsschemadata/qemu_2.9.0.x86_64.xml      |  1 +
>>  19 files changed, 39 insertions(+)
>>
>> diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng
>> index 39053181eb9a..dca5fa1c8fa0 100644
>> --- a/docs/schemas/domaincaps.rng
>> +++ b/docs/schemas/domaincaps.rng
>> @@ -28,6 +28,9 @@
>>          <optional>
>>            <ref name='vcpu'/>
>>          </optional>
>> +        <optional>
>> +          <ref name='iothreads'/>
>> +        </optional>
>>          <optional>
>>            <ref name='os'/>
>>          </optional>
>> @@ -53,6 +56,12 @@
>>      </element>
>>    </define>
>>
>> +  <define name='iothreads'>
>> +    <element name='iothreads'>
>> +      <empty/>
>> +    </element>
>> +  </define>
>
>Shouldn't this be <iothreads supported='yes'/> to be consistent with the
>rest of 'devices'?
>

I guess it makes sense to differentiate between QEMU not supporting I/O
threads and libvirt not being able to expose the support info in
capabilities.  v2 it is

>Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180424/d0e55caf/attachment-0001.sig>


More information about the libvir-list mailing list