[libvirt] [dbus PATCH 08/15] Implement GetHostname method for Domain Interface

Ján Tomko jtomko at redhat.com
Wed Apr 25 11:15:06 UTC 2018


On Wed, Apr 25, 2018 at 12:20:23PM +0200, Katerina Koukiou wrote:
>Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
>---
> data/org.libvirt.Domain.xml |  6 ++++++
> src/domain.c                | 28 ++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
>diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
>index 343fc08..1324db8 100644
>--- a/data/org.libvirt.Domain.xml
>+++ b/data/org.libvirt.Domain.xml
>@@ -209,6 +209,12 @@
>       <arg name="flags" type="u" direction="in"/>
>       <arg name="vcpus" type="a{sv}" direction="out"/>
>     </method>
>+    <method name="GetHostname">
>+      <annotation name="org.gtk.GDBus.DocString"
>+        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetHostname"/>
>+      <arg name="flags" type="u" direction="in"/>
>+      <arg name="hostname" type="s" direction="out"/>
>+    </method>
>     <method name="GetJobInfo">
>       <annotation name="org.gtk.GDBus.DocString"
>         value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetJobInfo"/>

The code looks good to me, but the API is only supported by the openvz
driver: https://libvirt.org/hvsupport.html
Is it worth exposing?

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180425/2f93b2d9/attachment-0001.sig>


More information about the libvir-list mailing list